Re: Cronolog jumbo patch fix

[Matthew Grosso <mgrosso@xxxxxxxxxxxxx>]

Hi,

Unfortunately you werent the first to get bit by this bug. I've fixed it to
respect the compile time defaults and also added runtime command line options
to override those.  Fortunately I've finally spent the few minutes it took to
put together a tarball with this fix and the changes represented by the jumbo
patch.

I've made it available so people can test it at:

http://www.nullo.org/~mgrosso/cronolog-1.7.0-beta.tar.gz

still todo:

    There are several new command line options that are only documented in the
    usage message. I'd love to update the man page but havent spent the time
    fiddling with it yet.   

    I'd be interested to get build and test reports from windows, mac osx, and
    other platforms.

Its still Andrew's baby, so he may well have different thoughts on the
approaches taken or the version number or qa or whatever.

Later,
Matt


On Aug 18 1737, Richard van den Berg wrote:
> Hi there,
> 
> I just started using cronolog in combination with the jumbo patch 
> provided by Matthew Grosso. I immediately spotted one problem: the jumbo 
> patch ignores the FILE_MODE define when creating new log files. As a 
> result, all files are created with mode 700. It's a trivial fix, but I 
> could not find any reports of it, so here it is.
> 
> Sincerely,
> 
> -- 
> Richard van den Berg, CISSP
> 
> Trust Factory B.V.      | http://www.trust-factory.com/
> Bazarstraat 44a         | Phone: +31 70 3620684
> NL-2518AK The Hague     | Fax  : +31 70 3603009
> The Netherlands         |
> 

> *** cronolog.c.org	Wed Aug 18 15:14:16 2004
> --- cronolog.c	Wed Aug 18 17:24:22 2004
> ***************
> *** 668,679 ****
>       int ret;
>       if( use_handler !=1 )
>       {
> !         return open(ofilename, OPEN_SHARED, S_IRWXU );
>       }
> !     ret = open(ofilename, OPEN_EXCLUSIVE, S_IRWXU );
>       if( ret < 0 )
>       {
> !         ret = open(ofilename, OPEN_SHARED, S_IRWXU );
>           i_am_handler= 0;
>       }
>       else
> --- 668,679 ----
>       int ret;
>       if( use_handler !=1 )
>       {
> !         return open(ofilename, OPEN_SHARED, FILE_MODE );
>       }
> !     ret = open(ofilename, OPEN_EXCLUSIVE, FILE_MODE );
>       if( ret < 0 )
>       {
> !         ret = open(ofilename, OPEN_SHARED, FILE_MODE );
>           i_am_handler= 0;
>       }
>       else


-- 
#######################################################################
# Matt Grosso mgrosso@xxxxxxxxxxxxx   w(201)963-2024 c(201)780-9592   #
# pgp public key is at http://www.falconweb.com/~mattg/publickey.pgp  #
#######################################################################